EWPP-1802: Improve live stream display. #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
previously approved these changes
Dec 9, 2021
22Alexandra
force-pushed
the
EWPP-1802
branch
from
3346279 to
a67d7c0
Compare
22Alexandra
previously approved these changes
Dec 20, 2021
ademarco
requested changes
Dec 21, 2021
| if (!$event->hasOnlineType() | ||
| || !$event->hasOnlineLink() | ||
| || !$event->hasOnlineDates() | ||
| || !$event->isOnlinePeriodYetToCome($this->requestDateTime)) { |
There was a problem hiding this comment.
It's ok to return empty if type, link and dates are empty (as, due to custom validation logic, filling one requires the other two to be filled as well), but we should isolate the isOnlinePeriodYetToCome check, so that we apply cache tags when type, link and dates are filled, but it's still not time to show the field.
|
|
||
| if ($event->isOnlinePeriodYetToCome($this->requestDateTime)) { | ||
| // Invalidate cache tags when livestream will be started. | ||
| $this->applyHourTag($build, $event->getOnlineStartDate()); |
There was a problem hiding this comment.
This is correct and it's basically what outlined in the comment above, on the other field, but we should consider marking the field as empty, instead of returning and empty array, as per extra field docs:
ademarco
previously requested changes
Dec 21, 2021
22Alexandra
force-pushed
the
EWPP-1802
branch
from
cdaa23a to
87573c5
Compare
nagyad
previously approved these changes
Jan 3, 2022
sergepavle
previously approved these changes
Jan 5, 2022
nagyad
previously approved these changes
Jan 5, 2022
sergepavle
previously approved these changes
Jan 5, 2022
nagyad
previously approved these changes
Jan 5, 2022
imanoleguskiza
suggested changes
Jan 7, 2022
| @@ -568,7 +572,16 @@ public function testEventRendering(): void { | |||
| $this->cronRun(); | |||
| $this->drupalGet($node->toUrl()); | |||
|
|
|||
| $description_summary = $this->assertSession()->elementExists('css', '.ecl', $details_content); | |||
| // It is time when livestream is active. | |||
| ]); | ||
| // If the livestream is ongoing, we add the livestream link. | ||
| if ($event->isOnlinePeriodActive($this->requestDateTime)) { | ||
| $link = $entity->get('oe_event_online_link')->first(); |
There was a problem hiding this comment.
We need to cache by the end date
imanoleguskiza
previously approved these changes
Jan 7, 2022
nagyad
previously approved these changes
Jan 7, 2022
22Alexandra
dismissed stale reviews from nagyad and imanoleguskiza
via
e2c83ae
22Alexandra
force-pushed
the
EWPP-1802
branch
3 times, most recently
from
5b21702 to
014c6c8
Compare
sergepavle
approved these changes
Jan 7, 2022
nagyad
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.