EWPP-1803: Theme extra fields. #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-1803
branch
2 times, most recently
from
7f631cd to
c1b6591
Compare
imanoleguskiza
suggested changes
Dec 6, 2021
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/LocationExtraField.php
Outdated
Show resolved
Hide resolved
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/MediaExtraField.php
Outdated
Show resolved
Hide resolved
modules/oe_theme_content_event/src/Plugin/ExtraField/Display/MediaExtraField.php
Outdated
Show resolved
Hide resolved
22Alexandra
force-pushed
the
EWPP-1803
branch
from
c4ed5b4 to
d04ea22
Compare
imanoleguskiza
previously approved these changes
Dec 12, 2021
nagyad
requested changes
Jan 3, 2022
| ]); | ||
| } | ||
| if (count($build['#items']) < 1) { | ||
| $this->isEmpty = TRUE; |
There was a problem hiding this comment.
I didn't fill any of these fields in.
There was a problem hiding this comment.
When I fill it in, I get double titles.
22Alexandra
force-pushed
the
EWPP-1803
branch
2 times, most recently
from
46792ea to
3d316a2
Compare
nagyad
previously approved these changes
Jan 3, 2022
imanoleguskiza
previously approved these changes
Jan 4, 2022
22Alexandra
dismissed stale reviews from imanoleguskiza and nagyad
via
183cab3
nagyad
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.