EWPP-1630: Add lists property to file-teaser. #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for this PR to be merged. #976 |
imanoleguskiza
previously requested changes
Nov 8, 2021
tests/Kernel/fixtures/rendering.yml
Outdated
| 'dl.ecl-description-list--taxonomy': 1 | ||
| 'dt.ecl-description-list__term': 1 | ||
| 'dd.ecl-description-list__definition': 1 | ||
| 'span.ecl-description-list__tag': 2 |
There was a problem hiding this comment.
I wonder if we should also check the contents of the tags and the terms
imanoleguskiza
force-pushed
the
EWPP-1630
branch
from
3fd6db3 to
e91ed63
Compare
22Alexandra
previously approved these changes
Nov 10, 2021
22Alexandra
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.