EWPP-1557: Translate "@date in" to Arabic and Turkish languages. #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenyasinn
force-pushed
the
EWPP-1478
branch
from
0dfb871 to
e1888c7
Compare
yenyasinn
force-pushed
the
EWPP-1557
branch
2 times, most recently
from
fbb2a85 to
6b2ebc1
Compare
22Alexandra
requested changes
Oct 4, 2021
22Alexandra
previously approved these changes
Oct 5, 2021
brummbar
requested changes
Oct 5, 2021
brummbar
requested changes
Oct 13, 2021
| $result = $this->container->get('renderer')->renderRoot($render_string); | ||
| $this->assertEquals('This a string with the <a href="http://www.example.com">link</a>', $result); | ||
|
|
||
| // Twig doesn't escape Markup object. |
There was a problem hiding this comment.
Suggested change
| // Twig doesn't escape Markup object. | |
| // Twig doesn't escape Markup objects. |
| * Test create_markup filter. | ||
| */ | ||
| public function testCreateMarkup() { | ||
| // Twig escapes strings from the variable by default. |
There was a problem hiding this comment.
Suggested change
| // Twig escapes strings from the variable by default. | |
| // Twig escapes string variables by default. |
| /** | ||
| * Test create_markup filter. | ||
| */ | ||
| public function testCreateMarkup() { |
There was a problem hiding this comment.
This test doesn't need Drupal to be bootstrapped, and it could be written as unit test in /modules/oe_theme_helper/tests/src/Unit/TwigExtensionTest.php.
We can test that the filter returns a markup object by doing $this->extension->createMarkup() too, aside from doing a render test.
brummbar
previously approved these changes
Oct 21, 2021
nagyad
previously approved these changes
Oct 22, 2021
upchuk
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.