EWPP-1540: Render the Media field of Event CT using the Media gallery formatter. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-1540
branch
from
b6db0b9 to
53bf9c3
Compare
sergepavle
reviewed
Sep 20, 2021
| $this->assertContains('placeholder_first_image.png', $first_item->getAttribute('src')); | ||
| $caption = $items[0]->find('css', '.ecl-gallery__description'); | ||
| $this->assertContains('Test image first_image', $caption->getOuterHtml()); | ||
| $this->assertEmpty($caption->find('css', '.ecl-gallery__meta')->getText()); | ||
| } |
There was a problem hiding this comment.
We can test also the second image I suppose.
There was a problem hiding this comment.
The info it's exactly the same and it would just make the test slower. Once we have the pattern assertions for gallery this should be replaced.
sergepavle
previously approved these changes
Sep 21, 2021
22Alexandra
force-pushed
the
EWPP-1540
branch
from
9a93a84 to
f009341
Compare
22Alexandra
force-pushed
the
EWPP-1540
branch
from
f009341 to
bccbb4c
Compare
sergepavle
approved these changes
Sep 28, 2021
nagyad
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.