EWPP-1362: Reorganise publication date extra field class. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademarco
requested changes
Aug 31, 2021
ademarco
approved these changes
Aug 31, 2021
yenyasinn
reviewed
Aug 31, 2021
| @@ -65,14 +70,20 @@ content: | |||
| third_party_settings: { } | |||
| hidden: | |||
| body: true | |||
| extra_field_oe_theme_content_news_date: true | |||
There was a problem hiding this comment.
Do we need also update teaser in update path?
Also I'm not sure that we need
$display = $storage->createFromStorageRecord($display_values);
$display->save();
in oe_theme_content_news_post_update_00009 because teaser and full displays should be there and if they were removed it was done intentionally. Looks like it is just copy paste from oe_theme_content_news_post_update_00003.
yenyasinn
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.