EWPP-1368: Update Sources and Related links fields rendering. #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
reviewed
Aug 27, 2021
| {{ item.content }} | ||
| {% endfor %} | ||
| </div> | ||
| <h3 class="ecl-u-type-heading-3">{{ 'Sources'|t }}</h3> |
There was a problem hiding this comment.
What do we change h2 to h3?
As I see we have h2 used in other headers.
There was a problem hiding this comment.
| </div> | ||
| <h3 class="ecl-u-type-heading-3">{{ 'Sources'|t }}</h3> | ||
| {% for item in items %} | ||
| {% set bubble_cache = item.content|render %} |
There was a problem hiding this comment.
Didn't find a way where we have an issue with bubbling cache. Is this issue exposed on ewcms?
On the component level, everything seems to work fine even without this.
There was a problem hiding this comment.
It is used correctly because we don't use {{ item.content }} anymore here, so without it cache isn't added.
yenyasinn
previously approved these changes
Aug 28, 2021
| {{ item.content }} | ||
| {% endfor %} | ||
| </div> | ||
| <h3 class="ecl-u-type-heading-3">{{ 'Sources'|t }}</h3> |
There was a problem hiding this comment.
| </div> | ||
| <h3 class="ecl-u-type-heading-3">{{ 'Sources'|t }}</h3> | ||
| {% for item in items %} | ||
| {% set bubble_cache = item.content|render %} |
There was a problem hiding this comment.
It is used correctly because we don't use {{ item.content }} anymore here, so without it cache isn't added.
yenyasinn
previously approved these changes
Sep 1, 2021
yenyasinn
approved these changes
Sep 7, 2021
sergepavle
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.