[EWPP-1360] EWPP-1388: Add icon optional parameter to list item pattern. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
changed the title
22Alexandra
changed the base branch from
EPIC-EWPP-1142-theme-ECL-v3
to
EPIC-EWPP-1360-News-v3
sergepavle
reviewed
Aug 9, 2021
sergepavle
previously approved these changes
Aug 10, 2021
sergepavle
reviewed
Aug 10, 2021
| @@ -53,6 +54,11 @@ | |||
| type: 'standalone', | |||
| label: title, | |||
| path: url | |||
| }, | |||
| icon: { | |||
There was a problem hiding this comment.
I still have doubts that it is safe. We rely on ecl-link ECL component implementation where we have to check that the icon name is not empty. But what if we will have a change in implementation. I don't sure that it is possible, but the chance still exists. It would be simpler to keep the empty icon element if we don't have the icon name from our side for explicitly declaring that link without an icon.
sergepavle
reviewed
Aug 10, 2021
nagyad
requested changes
Aug 11, 2021
nagyad
previously approved these changes
Aug 11, 2021
sergepavle
approved these changes
Aug 13, 2021
nagyad
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.