[EWPP-1360] EWPP-1363: Style Sources field in full view mode. #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
reviewed
Aug 3, 2021
Comment on lines
+9
to
+36
| <h2 class="ecl-u-type-heading-2">{{ 'Sources'|t }}</h2> | ||
| <div class="ecl-list"> | ||
| {% for item in items %} | ||
| <article class="ecl-content-item ecl-u-d-s-flex ecl-u-pb-m"> | ||
| <div class="ecl-u-flex-grow-1"> | ||
| <div class="ecl-content-item__title ecl-u-type-heading-5 ecl-u-mb-xs ecl-u-mt-none"> | ||
| {%- if item.content['#url'] %} | ||
| {% include '@ecl-twig/link' with { | ||
| link: { | ||
| type: 'standalone', | ||
| icon_position: 'after', | ||
| label: item.content['#title'], | ||
| path: item.content['#url'] | ||
| }, | ||
| icon: { | ||
| name: 'external', | ||
| size: 's', | ||
| path: ecl_icon_path | ||
| } | ||
| } %} | ||
| {% else %} | ||
| {{ item.content['#title'] }} | ||
| {%- endif -%} | ||
| </div> | ||
| </div> | ||
| </article> | ||
| {% endfor %} | ||
| </div> |
There was a problem hiding this comment.
Looks like it would be more suitable to reuse the list_item pattern like we did for related_links field.
See \oe_theme_preprocess_field function inside oe_theme.theme.
There was a problem hiding this comment.
Unfortunately, we can't, for now, use the list_item pattern according to fact that we can't control the link's icon. I think it would be the more preferable solution anyway to use a pattern but with additional parameter for controlling the link's type (for adding external icon if needed).
I suppose it can be impelmented in follow-up ticket.
sergepavle
previously approved these changes
Aug 3, 2021
nagyad
previously approved these changes
Aug 5, 2021
nagyad
approved these changes
Aug 5, 2021
sergepavle
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EWPP-1363
Description
Style Sources field in full view mode.
Change log