EWPP-1351: Fix templates for core and standard branding. #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
requested changes
Jul 30, 2021
22Alexandra
previously approved these changes
Aug 1, 2021
imanoleguskiza
suggested changes
Aug 2, 2021
imanoleguskiza
suggested changes
Aug 2, 2021
oe_theme.theme
Outdated
| @@ -1592,6 +1594,9 @@ function oe_theme_preprocess_page(array &$variables): void { | |||
| 'class' => ['ecl-u-pb-xl'], | |||
| 'id' => ['main-content'], | |||
| ]); | |||
| // Put 'data-ecl-has-menu' attribute only if we have a menu inside | |||
| // the site header. | |||
There was a problem hiding this comment.
After further testing, it turns out we are always adding the 'data-ecl-has-menu' because $variables['page']['navigation'] is never empty, at the very least it contains the cache information.
imanoleguskiza
approved these changes
Aug 3, 2021
22Alexandra
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands