EWPP-1288: Fix coding standards. #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademarco
force-pushed
the
EWPP-1288
branch
2 times, most recently
from
af4e7a1 to
dd978a0
Compare
yenyasinn
previously approved these changes
Jul 20, 2021
sergepavle
reviewed
Jul 20, 2021
| @@ -85,11 +85,13 @@ protected function assertFeaturedItemImage($expected_image, string $variant, Cra | |||
| */ | |||
| protected function assertLink($expected_link, string $variant, Crawler $crawler): void { | |||
| // Assert the title url points to the correct direction. | |||
| $this->assertElementAttribute($expected_link['href'], 'article.ecl-card header.ecl-card__header h1.ecl-card__title a.ecl-link', 'href', $crawler);; | |||
| $this->assertElementAttribute($expected_link['href'], 'article.ecl-card header.ecl-card__header h1.ecl-card__title a.ecl-link', 'href', $crawler); | |||
| ; | |||
|
|
||
| // If the variant is extended, assert that the button is correct. | ||
| if ($variant == 'extended') { | ||
| $this->assertElementAttribute($expected_link['href'], 'article.ecl-card div.ecl-card__body div.ecl-card__description a.ecl-button--call', 'href', $crawler);; | ||
| $this->assertElementAttribute($expected_link['href'], 'article.ecl-card div.ecl-card__body div.ecl-card__description a.ecl-button--call', 'href', $crawler); | ||
| ; |
sergepavle
approved these changes
Jul 20, 2021
yenyasinn
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.