Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-60: Drupal 9 Compatibility fixes. #880

Merged
merged 16 commits into from
Nov 8, 2021
Merged

OEL-60: Drupal 9 Compatibility fixes. #880

merged 16 commits into from
Nov 8, 2021

Conversation

escuriola
Copy link
Contributor

OPENEUROPA-60

Description

Fixes to upgrade oe_theme to Drupal 9

Change log

  • Added:
  • Changed:
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

@escuriola escuriola force-pushed the OEL-60 branch 9 times, most recently from 2b2cc92 to b538eb6 Compare July 19, 2021 12:07
claudiu-cristea
claudiu-cristea suggested changes Jul 19, 2021
View reviewed changes
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Functional/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
claudiu-cristea
claudiu-cristea suggested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few observations.

composer.json Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Kernel/RetinaScaleEffectTest.php Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Kernel/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
modules/oe_theme_helper/tests/src/Kernel/RetinaScaleEffectTest.php Outdated Show resolved Hide resolved
tests/Kernel/ValueObject/ImageTest.php Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
@escuriola escuriola mentioned this pull request Jul 21, 2021
Open
drishu
drishu reviewed Jul 22, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@abel-santos-corral abel-santos-corral changed the base branch from 2.x to 3.x August 3, 2021 07:47
@yenyasinn yenyasinn mentioned this pull request Aug 12, 2021
Closed
@yenyasinn yenyasinn force-pushed the OEL-60 branch 7 times, most recently from cd8c53f to b3ab83e Compare August 19, 2021 10:58
sergepavle
sergepavle requested changes Aug 26, 2021
View reviewed changes
Copy link
Member

@sergepavle sergepavle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left only 1 comment regarding dependencies for avoiding issues with the composer.
Also during testing I have found that we looks like have broken template for News content type:
Screenshot from 2021-08-26 19-41-41
It is related to config dependencies (don't sure even is it related to migration to D9).

composer.json Outdated
@@ -36,34 +36,36 @@
"drupal/inline_entity_form": "~1.0-rc9",
"drupal/json_field": "^1.0.0-rc2",
"drupal/renderviz": "^1.0@alpha",
"drupal/styleguide": "~1.0-alpha3",
"drupal/styleguide": "~1.0@beta",
"drupal/typed_link": "~1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be even removed as it is already required by oe_paragraphs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Removed

@yenyasinn
Copy link
Contributor

I've left only 1 comment regarding dependencies for avoiding issues with the composer.
Also during testing I have found that we looks like have broken template for News content type:
Screenshot from 2021-08-26 19-41-41
It is related to config dependencies (don't sure even is it related to migration to D9).

I've tested it locally again and it looks good for me:

Screenshot 2021-08-28 at 12 16 50

sergepavle
sergepavle previously approved these changes Aug 30, 2021
View reviewed changes
@sergepavle
Copy link
Member

I've left only 1 comment regarding dependencies for avoiding issues with the composer.
Also during testing I have found that we looks like have broken template for News content type:
Screenshot from 2021-08-26 19-41-41
It is related to config dependencies (don't sure even is it related to migration to D9).

I've tested it locally again and it looks good for me:

Screenshot 2021-08-28 at 12 16 50

Sorry, probably I forgot to mention that I used avportal photo media. for me is still reproducible. But I've created follow-up for that: EWPP-1472.

@yenyasinn
Copy link
Contributor

yenyasinn commented Aug 30, 2021 •
edited
Loading

Sorry, probably I forgot to mention that I used avportal photo media. for me is still reproducible. But I've created follow-up for that: EWPP-1472.

The issue exists in D8.

@imanoleguskiza imanoleguskiza merged commit 8c8aa09 into 3.x Nov 8, 2021
@imanoleguskiza imanoleguskiza deleted the OEL-60 branch November 8, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drishu drishu drishu left review comments

@imanoleguskiza imanoleguskiza imanoleguskiza approved these changes

@upchuk upchuk upchuk approved these changes

@yenyasinn yenyasinn yenyasinn approved these changes

@sergepavle sergepavle sergepavle left review comments

@claudiu-cristea claudiu-cristea claudiu-cristea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@escuriola @yenyasinn @sergepavle @claudiu-cristea @upchuk @drishu @imanoleguskiza @abel-santos-corral