[EWPP-1142] EWPP-1278: Update language switcher composition for ECL v3. #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
previously approved these changes
Jul 9, 2021
sergepavle
requested changes
Jul 12, 2021
There was a problem hiding this comment.
As I can see the patch for the page_header component still exist. According to the ticket scope, it was planned to remove.
Also after the installation of the component, I can't find any more content switcher block. We have to put this block in an appropriate place (region) or at least mention in the documentation for V3 migration that the content language switcher currently fully inside the block and should be placed manually.
templates/navigation/links--oe-multilingual-content-language-block.html.twig
Outdated
Show resolved
Hide resolved
...ates/compositions/ec-component-content-language-switcher/content-language-switcher.html.twig
Outdated
Show resolved
Hide resolved
ademarco
changed the title
ademarco
changed the title
ademarco
requested changes
Jul 22, 2021
ademarco
changed the title
ademarco
previously approved these changes
Jul 22, 2021
imanoleguskiza
force-pushed
the
EWPP-1278
branch
from
f39f340 to
43e3758
Compare
ademarco
previously approved these changes
Jul 26, 2021
sergepavle
reviewed
Jul 26, 2021
...ates/compositions/ec-component-content-language-switcher/content-language-switcher.html.twig
Outdated
Show resolved
Hide resolved
templates/navigation/links--oe-multilingual-content-language-block.html.twig
Outdated
Show resolved
Hide resolved
templates/navigation/links--oe-multilingual-content-language-block.html.twig
Outdated
Show resolved
Hide resolved
ademarco
approved these changes
Jul 26, 2021
sergepavle
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.