[EWPP-1142] EWPP-1250: Remove visibility condition for the main navigation block. #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
changed the title
22Alexandra
force-pushed
the
EWPP-1250
branch
3 times, most recently
from
df55c59 to
75cab58
Compare
imanoleguskiza
previously requested changes
Aug 2, 2021
| items: menu_items, | ||
| site_name: site_name, | ||
| }, 'vertical') }} | ||
| {% if menu_items %} |
There was a problem hiding this comment.
We don't need to check the menu_items twice, the pattern already checks if there is content to be rendered.
| @@ -46,5 +46,11 @@ | |||
| items: _items, | |||
| icon_path: ecl_icon_path | |||
| } only %} | |||
| {% elseif site_name and ecl_branding == 'standardised' %} | |||
There was a problem hiding this comment.
No need for this, its part of the page layout so it should not be part of the navigation menu.
22Alexandra
force-pushed
the
EWPP-1250
branch
3 times, most recently
from
8206e10 to
0e38982
Compare
nagyad
approved these changes
Aug 4, 2021
yenyasinn
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.