Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-4998: Remove is_current flag of navigation_menu's mega_menu variant. #1533

Merged
merged 1 commit into from
Dec 12, 2024
Merged

EWPP-4998: Remove is_current flag of navigation_menu's mega_menu variant. #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions templates/patterns/navigation_menu/navigation_menu.ui_patterns.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ navigation_menu:
items:
- href: "#"
label: "Featured link 2.1.1"
is_current: TRUE
- href: "#"
label: "Featured link 2.1.2"
- href: "#"
Expand Down Expand Up @@ -184,7 +183,6 @@ navigation_menu:
items:
- href: "#"
label: "Featured link 6.1.1"
is_current: TRUE
- href: "#"
label: "Featured link 6.1.2"
- href: "#"
Expand Down
20 changes: 0 additions & 20 deletions templates/patterns/navigation_menu/pattern-navigation-menu--variant-mega-menu.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,6 @@
see_all_attributes: child.see_all_attributes,
extra_attributes: child.extra_attributes,
} %}
{% if child.is_current is defined and child.is_current == true %}
{% set _child = _child|merge({
is_current: child.is_current,
}) %}
{% endif %}
{% if child.external is defined and child.external == true %}
{% set _child = _child|merge({
external: child.external,
Expand All @@ -40,11 +35,6 @@
label: grandchild.label,
extra_attributes: grandchild.extra_attributes,
} %}
{% if grandchild.is_current is defined and grandchild.is_current == true%}
{% set _grandchild = _grandchild|merge({
is_current: grandchild.is_current,
}) %}
{% endif %}
{% if grandchild.external is defined and grandchild.external == true %}
{% set _grandchild = _grandchild|merge({
external: grandchild.external,
Expand All @@ -68,11 +58,6 @@
label: featured_item.label,
extra_attributes: featured_item.extra_attributes,
} %}
{% if featured_item.is_current is defined and featured_item.is_current == true%}
{% set _featured_item = _featured_item|merge({
is_current: featured_item.is_current,
}) %}
{% endif %}
{% if featured_item.external is defined and featured_item.external == true %}
{% set _featured_item = _featured_item|merge({
external: featured_item.external,
Expand Down Expand Up @@ -141,11 +126,6 @@
}) %}
{% endif %}
{% endif %}
{% if item.is_current is defined and item.is_current == true %}
{% set _item = _item|merge({
is_current: item.is_current,
}) %}
{% endif %}
{% set _items = _items|merge([_item]) %}
{% endfor %}

Expand Down
1 change: 0 additions & 1 deletion tests/src/Kernel/fixtures/rendering.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4258,7 +4258,6 @@
children:
- href: '#'
label: 'Child 1.1'
is_current: true
external: true
extra_attributes:
- name: 'data-name2'
Expand Down