EWPP-4750: Add extra_attributes to patterns used to render node templates. #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-4750
branch
3 times, most recently
from
58a21d8 to
8cdc41a
Compare
nagyad
previously approved these changes
Sep 16, 2024
sergepavle
reviewed
Sep 18, 2024
| @@ -16,6 +16,8 @@ | |||
| {% set additional_information = additional_information|merge([additional_information_items]) %} | |||
| {% endif %} | |||
|
|
|||
| {% set extra_attributes = [] %} | |||
There was a problem hiding this comment.
I didn't get why in templates we added extra_attributes but before inserting set this empty. Is it intentional?
Because, in this case, external projects cannot set extra_attributes anyway.
22Alexandra
force-pushed
the
EWPP-4750
branch
from
603dc40 to
1f22bc4
Compare
sergepavle
previously approved these changes
Sep 19, 2024
22Alexandra
force-pushed
the
EWPP-4750
branch
2 times, most recently
from
e5cd868 to
0aa290a
Compare
22Alexandra
force-pushed
the
EWPP-4750
branch
from
0aa290a to
a36cf97
Compare
22Alexandra
force-pushed
the
EWPP-4750
branch
from
a36cf97 to
20b5453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.