EWPP-4551: Update ECL version. #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
force-pushed
the
EWPP-4551
branch
8 times, most recently
from
ac4488c to
c9909fa
Compare
22Alexandra
requested changes
Jul 25, 2024
There was a problem hiding this comment.
ECL 4.4.0 kinda removes the Banner component variants but keeps adding the classes to keep some sort of BC. Doing this, the rendering of the plain background variant is wrong: it renders both a plain background + the image if available.
This should not happen in EWCMS since the Plain background variant doesn't have an image field but we need to fix it in oe_theme. So, let's remove the image if available when rendering this variant. Please also add a test case to ensure this.
sergepavle
force-pushed
the
EWPP-4551
branch
2 times, most recently
from
a78a3bc to
107e9ed
Compare
22Alexandra
previously approved these changes
Jul 26, 2024
nagyad
previously approved these changes
Jul 26, 2024
22Alexandra
approved these changes
Aug 2, 2024
upchuk
approved these changes
Aug 2, 2024
nagyad
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands