EWPP-4496: Add Introduction field to various patterns. #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intelektron
force-pushed
the
EWPP-4496
branch
2 times, most recently
from
8d587f5 to
25e7ee8
Compare
22Alexandra
requested changes
Jul 16, 2024
| @@ -19,6 +20,14 @@ | |||
| </div> | |||
| </div> | |||
| {% endif %} | |||
| {% set _introduction = introduction|default('') %} | |||
There was a problem hiding this comment.
Why is this needed? Instead of moving the value from a variable to another, we can just check if introduction is not empty.
There was a problem hiding this comment.
I just followed the way from other components, I can change it.
intelektron
force-pushed
the
EWPP-4496
branch
2 times, most recently
from
f953074 to
fe09a9a
Compare
I've added the introduction field to pattern fixtures |
intelektron
force-pushed
the
EWPP-4496
branch
3 times, most recently
from
3f33ce9 to
66ce866
Compare
22Alexandra
previously approved these changes
Jul 23, 2024
upchuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EWPP-4496
Description
Add Introduction field to link lists.