Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-4356: Use source key of picture parameter for rendering different image sizes for each ECL breakpoint in Banner and Carousel. #1456

Merged
merged 9 commits into from
Aug 9, 2024

Conversation

22Alexandra
Copy link
Contributor

No description provided.

@22Alexandra 22Alexandra force-pushed the EWPP-4356 branch 2 times, most recently from 3193558 to b67cd7b Compare June 4, 2024 05:48
@fmmribeiro
Copy link
Contributor

Can the readme file be updated?
https://github.com/openeuropa/oe_theme?tab=readme-ov-file#image-styles

modules/oe_theme_helper/oe_theme_helper.post_update.php Outdated Show resolved Hide resolved
oe_theme.theme Outdated Show resolved Hide resolved
oe_theme.theme Outdated Show resolved Hide resolved
tests/src/PatternAssertions/CarouselAssert.php Outdated Show resolved Hide resolved
@22Alexandra 22Alexandra force-pushed the EWPP-4356 branch 2 times, most recently from 58979ea to 7dc8199 Compare June 10, 2024 09:12
fmmribeiro
fmmribeiro previously approved these changes Jun 11, 2024
nagyad
nagyad previously approved these changes Jun 12, 2024
nagyad
nagyad previously approved these changes Jul 15, 2024
@22Alexandra 22Alexandra merged commit b0458bf into 4.x Aug 9, 2024
1 check passed
@22Alexandra 22Alexandra deleted the EWPP-4356 branch August 9, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants