-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-4085: Add mega menu variant to navigation menu pattern. #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-4085
branch
2 times, most recently
from
March 26, 2024 10:09
389c8f0
to
9c1c954
Compare
22Alexandra
changed the title
EWPP-4085: Use ECL dev branch for mega-menu.
EWPP-4085: Add mega menu variant to navigation menu pattern.
Mar 26, 2024
22Alexandra
force-pushed
the
EWPP-4085
branch
2 times, most recently
from
April 3, 2024 15:19
7d67ec5
to
b9d3ecc
Compare
upchuk
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra_attributes dont work.
modules/oe_theme_helper/templates/oe-theme-helper-site-navigation.html.twig
Outdated
Show resolved
Hide resolved
22Alexandra
force-pushed
the
EWPP-4085
branch
2 times, most recently
from
April 17, 2024 08:38
deb12d7
to
65a22fb
Compare
sergepavle
previously approved these changes
Apr 18, 2024
templates/patterns/navigation_menu/pattern-navigation-menu--variant-mega-menu.html.twig
Outdated
Show resolved
Hide resolved
22Alexandra
force-pushed
the
EWPP-4085
branch
2 times, most recently
from
May 15, 2024 07:56
1da7f7e
to
7286a3f
Compare
22Alexandra
force-pushed
the
EWPP-4085
branch
2 times, most recently
from
May 30, 2024 12:18
660cc9f
to
24cecef
Compare
sergepavle
previously approved these changes
May 30, 2024
imanoleguskiza
previously approved these changes
Jun 3, 2024
upchuk
dismissed stale reviews from imanoleguskiza and sergepavle
June 7, 2024 07:03
The base branch was changed.
upchuk
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.