EWPP-4137: Cleanup deprecated patterns and fields and update README. #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-4137
branch
from
10cf1f7 to
931d9dd
Compare
22Alexandra
force-pushed
the
EWPP-4069
branch
from
fb48a26 to
7c7b4bf
Compare
22Alexandra
force-pushed
the
EWPP-4137
branch
from
931d9dd to
420a8ad
Compare
22Alexandra
force-pushed
the
EWPP-4137
branch
from
420a8ad to
b5eb873
Compare
ademarco
requested changes
Mar 6, 2024
| // phpcs:enable | ||
| $limit = 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
If we got NULL, in 3.x we were changing it to 0, what should we do now? We set the type to int in the argument?
public function smartTrim(Environment $env, $input, int $limit = 0) {
ademarco
approved these changes
Mar 6, 2024
nagyad
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.