Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EWPP-3913: Update ecl outdated classes. #1397

Merged
merged 1 commit into from
Feb 13, 2024
Merged

EWPP-3913: Update ecl outdated classes. #1397

merged 1 commit into from
Feb 13, 2024

Conversation

22Alexandra
Copy link
Contributor

No description provided.

imanoleguskiza
imanoleguskiza suggested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@imanoleguskiza imanoleguskiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed templates/patterns/icons_with_text/pattern-icons-with-text.html.twig and templates/patterns/dropdown/pattern-dropdown.html.twig

@22Alexandra
Copy link
Contributor Author

We missed templates/patterns/icons_with_text/pattern-icons-with-text.html.twig and templates/patterns/dropdown/pattern-dropdown.html.twig

It's fixed in #1395 which is ready for merging so I didn't want to duplicate.

imanoleguskiza
imanoleguskiza previously approved these changes Feb 13, 2024
View reviewed changes
sergepavle
sergepavle previously approved these changes Feb 13, 2024
View reviewed changes
@22Alexandra 22Alexandra changed the base branch from EPIC-EWPP-3676-ECL-v4 to 4.x February 13, 2024 13:06
@22Alexandra 22Alexandra merged commit 22b5be0 into 4.x Feb 13, 2024
1 check passed
@22Alexandra 22Alexandra deleted the EWPP-3913 branch February 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagyad nagyad nagyad approved these changes

@sergepavle sergepavle sergepavle approved these changes

@imanoleguskiza imanoleguskiza imanoleguskiza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@22Alexandra @sergepavle @imanoleguskiza @nagyad