EWPP-3874: Update Event CT. #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-3874
branch
from
257cb18 to
67462d3
Compare
22Alexandra
force-pushed
the
EWPP-3874
branch
2 times, most recently
from
2a0b457 to
99e4693
Compare
imanoleguskiza
suggested changes
Jan 26, 2024
modules/oe_theme_content_event/templates/oe-theme-content-event-contacts.html.twig
Outdated
Show resolved
Hide resolved
imanoleguskiza
previously approved these changes
Jan 29, 2024
22Alexandra
force-pushed
the
EWPP-3888
branch
from
3ab22a4 to
b3372ed
Compare
22Alexandra
dismissed
imanoleguskiza’s stale review
The base branch was changed.
|
@22Alexandra looks good but we have an issue with the calendar icon on mobile devices, see GIF below:
|
Unfortunately, there is not much to be fixed regarding this. This happens for any inline icon with long text in comparison with the inline icons with shorter text because it will need to fit the text on two lines. Please take a look the following video: icon.with.text.movUPDATE: The same behaviour on v3 in production: https://comm-ewcms-demo-ec.prd.fpfis.tech.ec.europa.eu/event-collection-demo/event-demo-2022-06-01_en |
ademarco
previously approved these changes
Jan 30, 2024
|
I see, it's an upstream problem, we should open a ticket on ECL then, I'll approve this for the time being. |
22Alexandra
force-pushed
the
EWPP-3874
branch
from
f70a894 to
a83599d
Compare
upchuk
approved these changes
Jan 31, 2024
sergepavle
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.