EWPP-3875: Update News CT rendering tests. #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
EWPP-3865-compile-sass
to
EPIC-EWPP-3676-ECL-v4
January 15, 2024 12:52
22Alexandra
force-pushed
the
EWPP-3875
branch
3 times, most recently
from
fa987c1 to
7779dba
Compare
sergepavle
approved these changes
Jan 18, 2024
… componentr flavour.
… language switcher.
22Alexandra
force-pushed
the
EWPP-3875
branch
from
fde74f8 to
8ba4ee6
Compare
sergepavle
previously approved these changes
Jan 22, 2024
ademarco
requested changes
Jan 22, 2024
| <h3 class="ecl-u-type-heading-3 ecl-u-mt-3xl">{{ 'Sources'|t }}</h3> | ||
| {% for item in items %} | ||
| {% set bubble_cache = item.content|render %} | ||
| <div class="ecl-u-border-bottom ecl-u-border-color-grey-15 ecl-u-pt-m ecl-u-pb-m"> | ||
| <div class="ecl-u-border-bottom ecl-u-border-color-{{ _color }} ecl-u-pt-m ecl-u-pb-m"> |
There was a problem hiding this comment.
Since we repeat this 5 times only in this PR, we could turn this into a Twig function that, depending on the library , prints out the right class, as ecl-u-border-color-{{ _color }}, like this:
Suggested change
| <div class="ecl-u-border-bottom ecl-u-border-color-{{ _color }} ecl-u-pt-m ecl-u-pb-m"> | |
| <div class="ecl-u-border-bottom {{ ecl_class_border_color() }} ecl-u-pt-m ecl-u-pb-m"> |
ademarco
approved these changes
Jan 22, 2024
sergepavle
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.