EWPP-3826: Remove spaceless filter from long text fields. #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donquixote
reviewed
Dec 15, 2023
| {%- include 'field--bare.html.twig' -%} | ||
| </div> | ||
| {% endapply %} | ||
| {% if not label_hidden %} |
There was a problem hiding this comment.
Suggested change
| {% if not label_hidden %} | |
| {%- if not label_hidden -%} |
Instead of the spaceless we can use the "-" in this and more places.
Not sure how many we need.
The purpose, from what I understand, is to remove whitespace caused by the template itself.
|
Also a test could be useful:
|
22Alexandra
approved these changes
Dec 20, 2023
imanoleguskiza
approved these changes
Jan 4, 2024
22Alexandra
approved these changes
Jan 15, 2024
imanoleguskiza
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.