EWPP-3633: Add support for CKEditor 5 #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
force-pushed
the
EWPP-3633
branch
3 times, most recently
from
590ef76 to
f7f0661
Compare
sergepavle
reviewed
Oct 16, 2023
modules/oe_theme_helper/tests/src/FunctionalJavascript/Ckeditor5TableTest.php
Show resolved
Hide resolved
sergepavle
previously approved these changes
Nov 20, 2023
nagyad
reviewed
Nov 23, 2023
nagyad
reviewed
Nov 23, 2023
nagyad
previously approved these changes
Nov 28, 2023
The previouse code waited for an iframe with a hidden status, which was causing ten seconds of wait wile the real element we need is the visible iframe.
…y up/down events.
It will be fixed in a dedicated issue.
brummbar
force-pushed
the
EWPP-3633
branch
2 times, most recently
from
28fd537 to
ca3c6ae
Compare
sergepavle
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.