Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EWPP-3479: Add optional expandable block to Text with featured media pattern. #1307

Merged
merged 3 commits into from
Sep 12, 2023
Merged

EWPP-3479: Add optional expandable block to Text with featured media pattern. #1307

merged 3 commits into from
Sep 12, 2023

Conversation

22Alexandra
Copy link
Contributor

No description provided.

Base automatically changed from EWPP-3489 to 3.x August 7, 2023 10:23
sergepavle
sergepavle previously approved these changes Aug 11, 2023
View reviewed changes
nagyad
nagyad requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@nagyad nagyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are errors on the event form and event page. Not sure if it is related.
image

@22Alexandra
Copy link
Contributor Author

There are errors on the event form and event page. Not sure if it is related. image

They're not related and they are generated by the helptext added by the Media modules regarding the allowed media types:
Type part of the media name. See the [media list](http://127.0.0.1:8080/build/en/admin/content/media) (opens a new window) to help locate media. Allowed media types: AV Portal Photo, AV Portal Video, Image, Remote video, ,
Basically the Iframe and Video iframe media types are allowed in the field but the module creating them is not installed. I fixed the dependencies in oe_content.

@22Alexandra 22Alexandra force-pushed the EWPP-3479 branch 2 times, most recently from 718520c to 026e80a Compare August 20, 2023 10:23
nagyad
nagyad previously approved these changes Aug 21, 2023
View reviewed changes
sergepavle
sergepavle previously approved these changes Aug 24, 2023
View reviewed changes
@22Alexandra 22Alexandra dismissed stale reviews from nagyad and sergepavle via 2ce28e1 September 1, 2023 11:04
sergepavle
sergepavle previously approved these changes Sep 1, 2023
View reviewed changes
@upchuk upchuk merged commit 057079c into 3.x Sep 12, 2023
@upchuk upchuk deleted the EWPP-3479 branch September 12, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagyad nagyad nagyad approved these changes

@sergepavle sergepavle sergepavle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@22Alexandra @sergepavle @nagyad @upchuk