EWPP-3240: Adapt the Site header container to new ECL Site header component. #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-3240
branch
5 times, most recently
from
4c04d98 to
f2f30c3
Compare
22Alexandra
force-pushed
the
EWPP-3240
branch
3 times, most recently
from
a0c147f to
a5402da
Compare
ademarco
previously approved these changes
Jun 16, 2023
nagyad
reviewed
Jun 16, 2023
| - "eu_category" (string) (default: ''); | ||
| - "non_eu_category" (string) (default: '') | ||
| - "items" (array) (default: []) | ||
| - "eu_category" (string) (default: '') Label for EU languages; |
| @@ -384,8 +384,13 @@ public function assertEuMobileLogo(string $language): void { | |||
| ]; | |||
| $lang_code = array_merge($lang_code, $available_non_eu_logos); | |||
| $langcode = $lang_code[$language] ?? 'en'; | |||
| $this->assertSession()->elementExists('css', 'img.ecl-site-header__logo-image-mobile'); | |||
| $this->assertSession()->elementAttributeContains('css', 'img.ecl-site-header__logo-image-mobile', 'src', 'oe_theme/dist/eu/images/logo/condensed-version/positive/logo-eu--' . $langcode . '.svg'); | |||
| // Assert the logos' wrapper. | |||
nagyad
previously approved these changes
Jun 16, 2023
|
Needs a rebase with 3.8.4. |
22Alexandra
dismissed stale reviews from nagyad and ademarco
The base branch was changed.
…tainer of page template.
nagyad
approved these changes
Jun 21, 2023
upchuk
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.