EWPP-3271: Theme Banner paragraph using the new ECL Banner component. #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-3271
branch
2 times, most recently
from
8d27256 to
d35c7ca
Compare
nagyad
requested changes
May 12, 2023
22Alexandra
force-pushed
the
EWPP-3271
branch
2 times, most recently
from
9d617e2 to
530177e
Compare
nagyad
approved these changes
May 15, 2023
nagyad
previously approved these changes
May 15, 2023
imanoleguskiza
suggested changes
May 16, 2023
oe_theme.theme
Outdated
| 'name' => $media->getName(), | ||
| ]; | ||
| $variables['image'] = ImageValueObject::fromArray($values); | ||
| $thumbnail = $media->get('thumbnail')->first(); |
There was a problem hiding this comment.
Same as in the carousel, lets use the actual image, not the thumbnail
| @@ -0,0 +1,7 @@ | |||
| name: OpenEuropa Theme Paragraphs Banner | |||
There was a problem hiding this comment.
LEts enable the module in the runner file for clean installs
imanoleguskiza
previously approved these changes
May 16, 2023
nagyad
previously approved these changes
May 16, 2023
22Alexandra
dismissed stale reviews from nagyad and imanoleguskiza
The base branch was changed.
nagyad
approved these changes
May 16, 2023
imanoleguskiza
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.