EWPP-2735: Row Header in Tables - Inconsistent text alignment. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
suggested changes
Mar 31, 2023
| // rows produce visual issues in mobile/tablet view. For avoiding such | ||
| // problems we can use 'simple display' instead of ECL enhanced one for | ||
| // mobile/tablet. | ||
| $span_cells = $xpath->query('.//*[self::th or self::td][(@colspan and @colspan > 1) or (@rowspan and @rowspan > 1)]', $table); |
There was a problem hiding this comment.
I don't think we need this fix, my tests didn't any issue with the mobile tables. In fact, adding the simple table display made the tables not adjust to the mobile view and to be much wider than the rest of the contents of the page.
There was a problem hiding this comment.
Yes indeed. Mobile/tablet view looks as it should be. We may keep responsive behavior.
imanoleguskiza
approved these changes
Apr 3, 2023
22Alexandra
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands