EWPP-3069: Update to ECL 3.7.0. #1240
Conversation
| centered: false | ||
| credit: "© Copyright first item" | ||
| - title: "Duis vitae pulvinar turpis" | ||
| description: "Integer quis lorem tellus. Nullam sollicitudin suscipit diam, ac blandit ipsum tempor consectetur" | ||
| url: "https://example.com" | ||
| url_text: "CTA" | ||
| image: "https://placeimg.com/640/480/arch" | ||
| variant: "image-gradient" | ||
| variant: "text-highlight" |
There was a problem hiding this comment.
It can be a tricky moment for other non-EWPP sites if they will try to use not existing anymore variants.
Does it make sense somehow deprecate variants (and in a nutshell show different variant)?
There was a problem hiding this comment.
I agree but we're rendering the Carousel paragraph using the ECL Carousel component directly. I mentioned in the Carousel pattern description that the items have to be compatible with the ECL Banner component so non-EWPP sites can check that.
For the Banner paragraph there is no issue for now because the deprecated components i.e Page and Hero Banners can still be used and for the Carousel paragraph, the variant cannot be changed and we set a default value.
We will deal with the new Banner component and variants changes in a follow up.
22Alexandra
force-pushed
the
EWPP-3069
branch
2 times, most recently
from
cc19504 to
ee1b420
Compare
22Alexandra
force-pushed
the
EWPP-3069
branch
2 times, most recently
from
27c80e7 to
5890636
Compare
No description provided.