-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-2875: Add EC logo and remove the title from EC footers. #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-2875
branch
2 times, most recently
from
December 7, 2022 13:50
892ecc8
to
d5d8703
Compare
nagyad
requested changes
Dec 7, 2022
22Alexandra
force-pushed
the
EWPP-2875
branch
from
December 8, 2022 10:22
b75afa1
to
d247a6a
Compare
nagyad
previously approved these changes
Dec 8, 2022
22Alexandra
force-pushed
the
EWPP-2875
branch
from
December 12, 2022 08:30
d247a6a
to
134e43e
Compare
nagyad
previously approved these changes
Dec 12, 2022
sergepavle
previously approved these changes
Dec 12, 2022
* @Then I should see the European Union footer with link :link label :label image alt :img_alt title :img_title | ||
*/ | ||
public function assertEuropeanUnionFooterBlockOnPage(string $link, string $label, string $img_alt, string $img_title): void { | ||
public function assertEuropeanFooterBlockOnPage(string $component_library, string $link, string $label, string $img_alt, string $img_title): void { | ||
// Make sure a corporate footer is present on the page. | ||
$this->assertSession()->elementExists('css', 'footer.ecl-site-footer'); | ||
// European Union footer is presented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it is not anymore only the European Union footer.
upchuk
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blind
yenyasinn
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.