Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-2875: Add EC logo and remove the title from EC footers. #1224

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

22Alexandra
Copy link
Contributor

No description provided.

@22Alexandra 22Alexandra force-pushed the EWPP-2875 branch 2 times, most recently from 892ecc8 to d5d8703 Compare December 7, 2022 13:50
oe_theme.theme Outdated Show resolved Hide resolved
oe_theme.theme Outdated Show resolved Hide resolved
oe_theme.theme Outdated Show resolved Hide resolved
nagyad
nagyad previously approved these changes Dec 8, 2022
nagyad
nagyad previously approved these changes Dec 12, 2022
sergepavle
sergepavle previously approved these changes Dec 12, 2022
* @Then I should see the European Union footer with link :link label :label image alt :img_alt title :img_title
*/
public function assertEuropeanUnionFooterBlockOnPage(string $link, string $label, string $img_alt, string $img_title): void {
public function assertEuropeanFooterBlockOnPage(string $component_library, string $link, string $label, string $img_alt, string $img_title): void {
// Make sure a corporate footer is present on the page.
$this->assertSession()->elementExists('css', 'footer.ecl-site-footer');
// European Union footer is presented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it is not anymore only the European Union footer.

Copy link
Contributor

@upchuk upchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind

@upchuk upchuk merged commit f390e93 into 3.x Dec 16, 2022
@upchuk upchuk deleted the EWPP-2875 branch December 16, 2022 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants