EWPP-2788: Add validation of path in \Drupal\oe_theme_helper\ExternalLinks::isExternalLink and update test coverage. #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
force-pushed
the
EWPP-2788
branch
from
d478c80 to
829cb7c
Compare
nagyad
requested changes
Nov 18, 2022
| $external_links->isExternalLink('randomschema'); | ||
| $external_links->isExternalLink('randomschema:'); | ||
| $external_links->isExternalLink('randomschema://'); | ||
| $external_links->isExternalLink('randomschema://test'); |
There was a problem hiding this comment.
I would add here some examples of drupal path like or similar.
…Links::isExternalLink and update test coverage.
sergepavle
force-pushed
the
EWPP-2788
branch
from
829cb7c to
1c8a264
Compare
nagyad
approved these changes
Nov 21, 2022
22Alexandra
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Links::isExternalLink and update test coverage.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands