EWPP-2718: Update ECL to 3.5.0 version. #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
previously approved these changes
Oct 24, 2022
22Alexandra
requested changes
Oct 24, 2022
22Alexandra
previously approved these changes
Oct 25, 2022
22Alexandra
force-pushed
the
EWPP-2718
branch
from
02cfa0b to
e8013e9
Compare
22Alexandra
previously approved these changes
Oct 27, 2022
upchuk
requested changes
Oct 27, 2022
composer.json
Outdated
| @@ -19,6 +19,7 @@ | |||
| "behat/behat": "^3.10", | |||
| "behat/mink-extension": "^2.3.1", | |||
| "composer/installers": "~1.5", | |||
| "consolidation/annotated-command": "4.5.6", | |||
| @@ -123,7 +123,7 @@ public function testEclMultiSelect(): void { | |||
|
|
|||
| // Assert all options are visible. | |||
| $options = [ | |||
| 'Select all', | |||
| 'Select all (4)', | |||
There was a problem hiding this comment.
Why is this happening? We cannot just change the test cause drone fails. There is a reason we have tests and that is to check if we break stuff. Not that if we break stuff, we just adapt the test. So please confirm what this is.
upchuk
approved these changes
Oct 27, 2022
22Alexandra
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.