EWPP-2506: Add classes to identify the last item per column. #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-2506-fixes
branch
from
f73fd85 to
005f827
Compare
sergepavle
previously approved these changes
Oct 20, 2022
nagyad
previously approved these changes
Oct 21, 2022
22Alexandra
force-pushed
the
EWPP-2506-fixes
branch
4 times, most recently
from
614c9de to
2ba35b5
Compare
…e pattern assertions.
22Alexandra
force-pushed
the
EWPP-2506-fixes
branch
from
2ba35b5 to
6d4e183
Compare
sergepavle
previously approved these changes
Oct 25, 2022
imanoleguskiza
previously requested changes
Oct 27, 2022
| @@ -153,9 +153,9 @@ | |||
| }]) %} | |||
| {% endif %} | |||
| {% endfor %} | |||
| {# Always use the horizontal variant of ECL Description list component for this pattern. #} | |||
| {# Always use the vertical variant of ECL Description list component for this pattern. #} | |||
There was a problem hiding this comment.
This comment is not very correct I would say. Shouldn't it be something like "Use the horizontal variant of ECL Description list component by default"?
sergepavle
approved these changes
Oct 31, 2022
yenyasinn
approved these changes
Oct 31, 2022
nagyad
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.