EWPP-2646: Fix publication thumbnail translation render. #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyad
force-pushed
the
EWPP-2646
branch
2 times, most recently
from
0606baf to
256a679
Compare
sergepavle
approved these changes
Oct 7, 2022
sergepavle
previously approved these changes
Oct 7, 2022
22Alexandra
requested changes
Oct 11, 2022
| */ | ||
| public function testPublicationThumbnailMediaTranslation(): void { | ||
| // Make publication node and image media translatable. | ||
| \Drupal::service('content_translation.manager')->setEnabled('node', 'oe_publication', TRUE); |
There was a problem hiding this comment.
The bundle is already translatable because this is done in the setUp() method.
| /** | ||
| * Tests that the Publication thumbnail media renders the translated media. | ||
| */ | ||
| public function testPublicationThumbnailMediaTranslation(): void { |
There was a problem hiding this comment.
Why can't we test this in the previous test method? The title field is set to be translatable in the setUp() and then the translation of the node is being tested. We can just do all the configuration needed in the setUp() and then provide a Thumbnail for the publication node so we can test this scenario too.
There was a problem hiding this comment.
Because that method is over 400 lines. I don't like shovelling everything under one test case. Here we test a specific scenario and this scenario is separate for event as well.
22Alexandra
previously approved these changes
Oct 13, 2022
sergepavle
previously approved these changes
Oct 13, 2022
22Alexandra
approved these changes
Nov 3, 2022
hernani
approved these changes
Nov 3, 2022
sergepavle
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.