EWPP-2507: Update the list_item pattern to use the ECL Content item component. #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
force-pushed
the
EWPP-2507
branch
3 times, most recently
from
1f40104 to
ff28086
Compare
22Alexandra
force-pushed
the
EWPP-2507
branch
from
ff28086 to
a0bb48d
Compare
22Alexandra
force-pushed
the
EWPP-2577
branch
7 times, most recently
from
b5cbbb9 to
b677fdc
Compare
22Alexandra
force-pushed
the
EWPP-2507
branch
from
a0bb48d to
20b3358
Compare
imanoleguskiza
previously approved these changes
Sep 9, 2022
sergepavle
previously approved these changes
Sep 9, 2022
| @@ -819,7 +819,7 @@ function oe_theme_preprocess_paragraph__oe_list_item(array &$variables): void { | |||
| $cacheability = CacheableMetadata::createFromRenderArray($variables); | |||
|
|
|||
| // Extract the image if present. | |||
| if (!$paragraph->get('field_oe_image')->isEmpty()) { | |||
| if (!$paragraph->get('field_oe_image')->isEmpty() && $variables['variant'] !== 'default') { | |||
There was a problem hiding this comment.
I didn't get why the image is not allowed to default variant. In templates/patterns/list_item/pattern-list-item.html.twig image is used for the picture variable.
nagyad
dismissed stale reviews from sergepavle and imanoleguskiza
The base branch was changed.
sergepavle
force-pushed
the
EWPP-2507
branch
2 times, most recently
from
0a5e1b7 to
6e41430
Compare
sergepavle
force-pushed
the
EWPP-2507
branch
from
6e41430 to
bb6c262
Compare
…d processing render array.
sergepavle
approved these changes
Sep 15, 2022
nagyad
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.