EPIC-EWPP-2022-External-links #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWPP-2071: Add external icon to external custom footer links.
EWPP-2070: Allow <svg> and <use> in introduction fileds.
EWPP-2022: Update epic with 3.x.
Update EPIC-EWPP-2022
EWPP-2069: External link icon for patterns rendering links.
EWPP-2072: Update link fields to render external icon.
This reverts commit 3355d04.
EWPP-2071: Add external icon to external custom footer links.
EWPP-2274: Use external link service.
Update EPIC-EWPP-2022-External-links.
Update EPIC-EWPP-2022
EWPP-2307: Add external_link parameter to node teaser templates.
EWPP-2022: Update External links epic branch.
ademarco
previously requested changes
Jun 17, 2022
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function isExternalLink($url): bool { |
There was a problem hiding this comment.
We should cover this with a dedicated test, where we throw at it all sorts of different values, of different types, and check the output.
| } | ||
|
|
||
| // If it's an external link, make sure its domain is not internal. | ||
| $internal_domain_expression = $this->configFactory->get('oe_theme_helper.internal_domains')->get('internal_domain'); |
There was a problem hiding this comment.
We can get the expression in the constructor, as we really don't need the config factory for anything else in this service.
Let's have a property called $internalDomainExpression, and we simply fill it in in the constructor.
EWPP-2022: Provide test coverage for the external links service.
EWPP-2022: Update epic branch.
EWPP-2022: Update EPIC-EWPP-2022.
22Alexandra
dismissed
ademarco’s stale review
Comments were addressed here #1125
imanoleguskiza
approved these changes
Jun 21, 2022
nagyad
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.