Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OEL-1362: ImageValueObject doesn't inherit cache information from image file. #1089

Merged
merged 3 commits into from
May 10, 2022
Merged

OEL-1362: ImageValueObject doesn't inherit cache information from image file. #1089

merged 3 commits into from
May 10, 2022

Conversation

escuriola
Copy link
Contributor

OPENEUROPA-OEL-1362

Description

In oe_bootstrap_theme we updated the ImageValueObject. The idea is align both ImageValueObject class and tests.

Change log

  • Added:
  • Changed:
  • Deprecated:
  • Removed:
  • Fixed:
  • Security:

Commands

[Insert commands here]

drishu
drishu requested changes Apr 27, 2022
View reviewed changes
oe_theme.theme Outdated Show resolved Hide resolved
src/ValueObject/ImageValueObject.php Outdated Show resolved Hide resolved
tests/src/Kernel/ValueObject/ImageValueObjectTest.php Outdated Show resolved Hide resolved
tests/src/Kernel/ValueObject/ImageValueObjectTest.php Show resolved Hide resolved
drishu
drishu reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@drishu drishu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update also the PR title and have a better PR description, thx

brummbar
brummbar requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@brummbar brummbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the PR so that I review it.

@brummbar brummbar changed the title OEL-1362: ImageValueObject add cache available. Adapt code and tests. OEL-1362: ImageValueObject doesn't inherit cache information from image file. May 4, 2022
brummbar
brummbar requested changes May 4, 2022
View reviewed changes
templates/patterns/list_item/list_item.ui_patterns.yml Outdated Show resolved Hide resolved
oe_theme.theme Outdated Show resolved Hide resolved
tests/src/Unit/ValueObject/ImageValueObjectTest.php Outdated Show resolved Hide resolved
@escuriola escuriola force-pushed the OEL-1362 branch 2 times, most recently from 325bbd5 to a879443 Compare May 9, 2022 14:30
@brummbar
Copy link
Contributor

brummbar commented May 9, 2022

I wrote to drop all the mocked parts, not just that line. Obviously now the PR is broken.
I'm taking over. I'll also drop the commits that change and restore the pattern signature. These back-and-forth commits make longer the git blame process and have 0 value.

@brummbar brummbar merged commit 34d2516 into 3.x May 10, 2022
@brummbar brummbar deleted the OEL-1362 branch May 10, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donquixote donquixote donquixote left review comments

@drishu drishu drishu approved these changes

@brummbar brummbar brummbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@escuriola @brummbar @donquixote @drishu