EWPP-2071: Add external icon to external custom footer links. #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22Alexandra
requested changes
Mar 24, 2022
22Alexandra
requested changes
Mar 24, 2022
22Alexandra
approved these changes
Mar 25, 2022
22Alexandra
requested changes
Mar 25, 2022
There was a problem hiding this comment.
There is a Twig function (ecl_footer_links) currently used in the footer templates that is supposed to add the external icon but it doesn't seem working. @nagyad can you please check if we can fix it instead of adding the helper function for the preprocess?
22Alexandra
requested changes
Mar 27, 2022
22Alexandra
previously approved these changes
Mar 28, 2022
yenyasinn
approved these changes
Mar 29, 2022
22Alexandra
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.