EWPP-2016: Improve display of person teaser. #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
force-pushed
the
EWPP-2016
branch
3 times, most recently
from
be10230 to
364e0f9
Compare
sergepavle
reviewed
Mar 7, 2022
sergepavle
previously approved these changes
Mar 15, 2022
sergepavle
force-pushed
the
EWPP-2016
branch
2 times, most recently
from
cadc7c3 to
18d6cf2
Compare
22Alexandra
requested changes
Mar 23, 2022
There was a problem hiding this comment.
This request from the ticket is missing: Point 1. 2. and 3. should apply to all instances of the content item pattern, not only on person teaser.
So we need to hide the contact name everywhere we render contacts and separate departments by comma instead of pipe too.
templates/field/field--node--oe-departments--oe-person--teaser.html.twig
Show resolved
Hide resolved
sergepavle
force-pushed
the
EWPP-2016
branch
2 times, most recently
from
706b4d5 to
90fbda0
Compare
22Alexandra
previously approved these changes
Mar 30, 2022
yenyasinn
reviewed
Mar 31, 2022
yenyasinn
previously approved these changes
Mar 31, 2022
yenyasinn
previously approved these changes
Apr 1, 2022
imanoleguskiza
force-pushed
the
EWPP-2016
branch
from
d873788 to
910a9cd
Compare
…tender content type.
yenyasinn
approved these changes
Apr 6, 2022
22Alexandra
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EWPP-2016
Description
[Insert description here]
Change log
Commands