EWPP-2018: Style highlighted Text with featured media paragraph. #1049
Conversation
22Alexandra
force-pushed
the
EWPP-2018
branch
4 times, most recently
from
3b30a2d to
f663080
Compare
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
templates/patterns/text_featured_media/pattern-text-featured-media.html.twig
Outdated
Show resolved
Hide resolved
| <div class="ecl-featured-item__title">{{ text_title }}</div> | ||
| {% endif %} | ||
| {% if text %} | ||
| <div class="ecl">{{ text }}</div> |
There was a problem hiding this comment.
| <div class="ecl">{{ text }}</div> | |
| <div class="ecl-featured-item__description ecl">{{ text }}</div> |
There was a problem hiding this comment.
We can't use this class, check the FRONT ticket linked in our ticket.
There was a problem hiding this comment.
If you are talking about https://citnet.tech.ec.europa.eu/CITnet/jira/browse/FRONT-3561, could you please check PR https://github.com/ec-europa/europa-component-library/pull/2351/files and playground https://ecl-preview-2351--europa-component-library.netlify.app/playground/ec/?path=/story/components-featured-item--extended.
Class ecl-featured-item__description is still used. Changes are just in the removing of font size.
There was a problem hiding this comment.
Also would be nice to set extra_classes: 'ecl-featured-item__link ecl-u-mt-m ecl-u-type-bold', for call to action button https://github.com/openeuropa/oe_theme/pull/1049/files#diff-1fb33e85cf11b49744aeae0c0e8b9daaa3ad245ec4ca2fb9bbd735a02b1d14f7R33 .
I know that it is out of scope but currently we have 2 classes for top margin and margin is incorrect.
There was a problem hiding this comment.
If you are talking about https://citnet.tech.ec.europa.eu/CITnet/jira/browse/FRONT-3561, could you please check PR https://github.com/ec-europa/europa-component-library/pull/2351/files and playground https://ecl-preview-2351--europa-component-library.netlify.app/playground/ec/?path=/story/components-featured-item--extended.
Class
ecl-featured-item__descriptionis still used. Changes are just in the removing of font size.
I see it's fixed but not released, what should we do? Block the ticket on the ECL upgrade? ECL still needs to do improvements for this component so we can drop all our customisation and use their component.
The other comment is out of scope, indeed. The links are properly working and the scope of the ticket was to integrate the highlighted display which has been done.
There was a problem hiding this comment.
Do we need to create a ticket just for one class? Can't we simply remove it while we rebuild the whole template?
There was a problem hiding this comment.
We can't use ECL component now since it doesn't support image on the right and links instead of button.
22Alexandra
force-pushed
the
EWPP-2018
branch
3 times, most recently
from
2b55dad to
3b7e5bc
Compare
No description provided.