EWPP-1996: Fix DefaultNodeMetadataEventSubscriber. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
Feb 21, 2022
| @@ -75,7 +75,7 @@ public function getNode(NodeMetadataEvent $event): void { | |||
|
|
|||
| if ($this->currentRouteMatch->getRouteName() === 'entity.node.revision') { | |||
| $node_revision = $this->currentRouteMatch->getParameter('node_revision'); | |||
| $node = $this->entityTypeManager->getStorage('node')->loadRevision($node_revision); | |||
| $node = $this->entityTypeManager->getStorage('node')->loadRevision($node_revision->getRevisionId()); | |||
There was a problem hiding this comment.
Please see why this is not failing any test with 9.2 since with that version I believe we used to get an ID and not an entity object as a route parameter. if you confirm there is a difference between 9.2 and 9.3, you should check here if it's an entity or just an ID and put a comment wy.
22Alexandra
force-pushed
the
EWPP-1996
branch
from
aaa081e to
a310d38
Compare
upchuk
previously approved these changes
Feb 21, 2022
22Alexandra
force-pushed
the
EWPP-1996
branch
from
a310d38 to
f074a5e
Compare
upchuk
approved these changes
Feb 23, 2022
yenyasinn
approved these changes
Feb 23, 2022
nagyad
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.