Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EWPP-1983: Replace event date fields with timezone ones. #1039

Merged
merged 1 commit into from
Mar 4, 2022
Merged

EWPP-1983: Replace event date fields with timezone ones. #1039

merged 1 commit into from
Mar 4, 2022

Conversation

nagyad
Copy link
Member

@nagyad nagyad commented Feb 15, 2022

No description provided.

@nagyad nagyad force-pushed the EWPP-1983 branch 6 times, most recently from 8707531 to 81c4e3a Compare February 17, 2022 12:43
sergepavle
sergepavle reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@sergepavle sergepavle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some findings:

  1. Seems like for Livestream field we don't have timezone visible:
    image

  2. is it expected that we are doing duplication of timezone for start and end date (on node edit page we are selecting timezone only for both dates):

image

@nagyad
Copy link
Member Author

nagyad commented Feb 22, 2022

We have duplicate because we are using php format, and that is applied to each date one by one.

sergepavle
sergepavle previously approved these changes Feb 22, 2022
View reviewed changes
@nagyad nagyad force-pushed the EWPP-1983 branch 3 times, most recently from 467b719 to 8887f8d Compare March 1, 2022 15:20
22Alexandra
22Alexandra approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@22Alexandra 22Alexandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind

@nagyad nagyad merged commit cab290b into EPIC-EWPP-1539-Event-v2 Mar 4, 2022
@nagyad nagyad deleted the EWPP-1983 branch March 4, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@22Alexandra 22Alexandra 22Alexandra approved these changes

@imanoleguskiza imanoleguskiza imanoleguskiza approved these changes

@yenyasinn yenyasinn yenyasinn approved these changes

@sergepavle sergepavle sergepavle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nagyad @yenyasinn @sergepavle @imanoleguskiza @22Alexandra