EWPP-1973: Remove usage of t() in test assertions. #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
previously requested changes
Feb 10, 2022
yenyasinn
commented
Feb 11, 2022
| @@ -72,3 +72,41 @@ Feature: Site branding | |||
| Then I should see the "page header" element in the "page" | |||
| When I am on "the user registration page" | |||
| Then I should see the "page header" element in the "page" | |||
|
|
|||
| @javascript @enable-non-eu-language | |||
There was a problem hiding this comment.
This is a refactoring of the test from EWPP-1854. Since we need to ensure correctness of the data in the logo in different languages we need to pass them into the Behat context.
yenyasinn
commented
Feb 11, 2022
| */ | ||
| public function assertFooter(string $component_library, bool $presence): void { |
There was a problem hiding this comment.
assertFooter includes 3 functions - checks EU footer, checks EC footer, ensures that footer doesn't exist.
For logic simplification I've rewritten it, otherwise it is mess of conditions.
yenyasinn
force-pushed
the
EWPP-1973
branch
2 times, most recently
from
9fa9059 to
af53478
Compare
22Alexandra
previously requested changes
Feb 28, 2022
22Alexandra
dismissed
their stale review
I don't fully agree with the changes on this PR so I'll leave it for someone else to check.
22Alexandra
force-pushed
the
EWPP-1973
branch
2 times, most recently
from
e7fe079 to
e5b3e6c
Compare
22Alexandra
previously approved these changes
Jul 26, 2022
nagyad
approved these changes
Aug 31, 2022
22Alexandra
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.