EWPP-1901: Update registration button information at the exact time. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
previously requested changes
Feb 14, 2022
| */ | ||
| (function (Drupal, drupalSettings) { | ||
| /** | ||
| * Shows related information when registration is active. |
There was a problem hiding this comment.
Maybe something like: Shows registration information when the registration period is open.
| @@ -76,22 +76,13 @@ protected function isCurrentDay(int $timestamp): bool { | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can we improve the method description for isCurrentDay? Maybe something like: Asserts if a given timestamp corresponds to the same day of the current request time.
| namespace Drupal\oe_theme_content_event\Plugin\ExtraField\Display; | ||
|
|
||
| /** | ||
| * Base class for fields that require display livestream link in exact time. |
There was a problem hiding this comment.
Maybe: Base class for fields rendering livestream information.
| @@ -21,6 +21,8 @@ function oe_theme_content_event_theme() { | |||
| 'label' => '', | |||
| 'url' => '', | |||
| 'description' => '', | |||
| 'approaching_time_description' => '', | |||
| 'approaching_time' => FALSE, | |||
There was a problem hiding this comment.
This name is a bit confusing. How about we call it "registration_day" and "registration_day_description"?
sergepavle
force-pushed
the
EWPP-1901
branch
from
253e762 to
3760fca
Compare
22Alexandra
requested changes
Feb 16, 2022
modules/oe_theme_content_event/tests/src/FunctionalJavascript/InfoDisclosureExtraFieldTest.php
Outdated
Show resolved
Hide resolved
modules/oe_theme_content_event/tests/src/FunctionalJavascript/InfoDisclosureExtraFieldTest.php
Outdated
Show resolved
Hide resolved
modules/oe_theme_content_event/tests/src/FunctionalJavascript/InfoDisclosureExtraFieldTest.php
Outdated
Show resolved
Hide resolved
sergepavle
force-pushed
the
EWPP-1901
branch
from
063051e to
4c67a6d
Compare
22Alexandra
previously approved these changes
Feb 16, 2022
sergepavle
force-pushed
the
EWPP-1901
branch
3 times, most recently
from
0b5b2b4 to
87c5e80
Compare
22Alexandra
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands