-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-1864: Style the lists with illustrations paragraphs #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5b109de)
…ion list to simple fields.
brummbar
previously requested changes
Jan 26, 2022
'column': column, | ||
'zebra': zebra, | ||
'items': items, | ||
'squared': squared |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove any reference in our code to "squared", it's an incorrect word as I wrote in the tickets. This should be either "square_image", or "image_ratio" with options "default" or "square".
sergepavle
previously approved these changes
Jan 27, 2022
imanoleguskiza
suggested changes
Jan 31, 2022
templates/patterns/list_with_illustration/list_with_illustration.ui_patterns.yml
Show resolved
Hide resolved
yenyasinn
commented
Jan 31, 2022
yenyasinn
force-pushed
the
EWPP-1864-2
branch
from
January 31, 2022 16:31
21a0629
to
4dd0d1e
Compare
imanoleguskiza
approved these changes
Feb 1, 2022
sergepavle
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.