EWPP-1854: Adapt HTML attributes to improve accessibility and behavior of the Logo link in header and footer. #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenyasinn
reviewed
Jan 24, 2022
| public function assertHeaderLogoAccessibility(string $language): void { | ||
| $theme_name = \Drupal::theme()->getActiveTheme()->getName(); | ||
| $component_library = \Drupal::config($theme_name . '.settings')->get('component_library'); | ||
| $eu_official_languages = [ |
There was a problem hiding this comment.
Can we use oe_theme/modules/oe_theme_helper/src/EuropeanUnionLanguages.php as a single entry point for EU languages ?
yenyasinn
previously approved these changes
Jan 25, 2022
nagyad
previously approved these changes
Jan 26, 2022
yenyasinn
approved these changes
Feb 3, 2022
nagyad
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands