EWPP-1888: Handle non-eu logos provided by ECL 3.2. #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
Jan 20, 2022
There was a problem hiding this comment.
We said in the refinement we will check for the existence of the file on the system and then default to EN. i understand these two lang codes have different codes and we need a mapping but what about other languages (like catalan)? Or future languages that are added to the system and have a matching correct code.
22Alexandra
requested changes
Jan 21, 2022
22Alexandra
previously approved these changes
Jan 21, 2022
22Alexandra
force-pushed
the
EWPP-1890
branch
from
440017e to
368a44b
Compare
sergepavle
requested changes
Jan 28, 2022
sergepavle
previously approved these changes
Jan 28, 2022
imanoleguskiza
dismissed stale reviews from sergepavle and 22Alexandra
via
b3922fe
yenyasinn
force-pushed
the
EWPP-1888
branch
4 times, most recently
from
19a118c to
531270c
Compare
imanoleguskiza
force-pushed
the
EWPP-1888
branch
from
531270c to
2642d5a
Compare
22Alexandra
approved these changes
Feb 7, 2022
sergepavle
approved these changes
Feb 7, 2022
upchuk
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.