EWPP-3310: Fix ECL footer tests.

openeuropa · May 22, 2023 · efa2345 · efa2345
1 parent ce96634
commit efa2345
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 11 deletions.
diff --git a/.drone.yml b/.drone.yml
@@ -162,6 +162,6 @@ matrix:
     - { PHP_VERSION: 8.0, COMPOSER_BOUNDARY: highest, TYPE: phpunit, BATCH: batch2 }
     - { PHP_VERSION: 8.0, COMPOSER_BOUNDARY: highest, TYPE: phpunit, BATCH: batch3 }
     - { PHP_VERSION: 8.1, COMPOSER_BOUNDARY: highest, TYPE: behat }
-    - { PHP_VERSION: 8.1, COMPOSER_BOUNDARYf: highest, TYPE: phpunit, BATCH: batch1 }
+    - { PHP_VERSION: 8.1, COMPOSER_BOUNDARY: highest, TYPE: phpunit, BATCH: batch1 }
     - { PHP_VERSION: 8.1, COMPOSER_BOUNDARY: highest, TYPE: phpunit, BATCH: batch2 }
     - { PHP_VERSION: 8.1, COMPOSER_BOUNDARY: highest, TYPE: phpunit, BATCH: batch3 }
diff --git a/templates/patterns/gallery/pattern-gallery.html.twig b/templates/patterns/gallery/pattern-gallery.html.twig
@@ -56,6 +56,7 @@
     },
   },
   'view_all_label': "See all"|t,
+  'view_all_expanded_label': "Back"|t,
   'counter_label': "media items"|t,
   'items': _items
 } %}

diff --git a/tests/src/Functional/CorporateFooterRenderTest.php b/tests/src/Functional/CorporateFooterRenderTest.php
@@ -935,13 +935,7 @@ protected function assertSocialLink(NodeElement $label, NodeElement $link, array
    *   The component library: 'European Commission' or 'European Union'.
    */
   protected function assertEclLogoPresence(NodeElement $section, string $component_library): void {
-    if ($component_library === 'European Union') {
-      $this->assertSession()->elementsCount('css', "a img.ecl-site-footer__logo-image-mobile", 1, $section);
-      $this->assertSession()->elementsCount('css', "a img.ecl-site-footer__logo-image-desktop", 1, $section);
-    }
-    else {
-      $this->assertSession()->elementsCount('css', "a img.ecl-site-footer__logo-image-desktop", 1, $section);
-    }
+    $this->assertSession()->elementsCount('css', "a img.ecl-site-footer__logo-image", 1, $section);
   }
 
   /**

diff --git a/tests/src/PatternAssertions/FeaturedItemAssert.php b/tests/src/PatternAssertions/FeaturedItemAssert.php
@@ -65,14 +65,14 @@ protected function assertBaseElements(string $html, string $variant): void {
    *   The DomCrawler where to check the element.
    */
   protected function assertFeaturedItemImage($expected_image, string $variant, Crawler $crawler): void {
-    $image_div_selector = 'article.ecl-card div.ecl-card__image';
+    $image_div_selector = 'article.ecl-card img.ecl-card__image';
     if (is_null($expected_image)) {
       $this->assertElementNotExists($image_div_selector, $crawler);
       return;
     }
     $image_div = $crawler->filter($image_div_selector);
-    self::assertEquals($expected_image['alt'], $image_div->attr('aria-label'));
-    self::assertStringContainsString($expected_image['src'], $image_div->attr('style'));
+    self::assertEquals($expected_image['alt'], $image_div->attr('alt'));
+    self::assertStringContainsString($expected_image['src'], $image_div->attr('src'));
   }
 
   /**